Monthly Archives: November 2009

Home/2009/November

Terrible Code

request.setParameter("qualifySkus", getSkusRepository(d, cItem));

  1. “qualifySkus” is confusing. Is it an array/list/collection of “qualifiedSKUs” or a flag that’s a result of “qualifyingSkus” or….
  2. “qualifySKus” should be a constant with a nice comment, not an in-line String.
  3. The method getSkusRespository seems like it would return a catalog repository, doesn’t it? Instead it takes in a List […]
By | 2010-01-29T14:12:36+00:00 November 2nd, 2009|ATG|2 Comments