Comments on: Setting Cache Headers from JBoss

By: Devon

Devon — Thu, 23 Sep 2010 14:38:36 +0000

Hmm I haven’t used Portlets in JBoss so I’m not sure what gotchas there may be. What errors are you getting, if any?

By: kvic

kvic — Thu, 23 Sep 2010 03:08:10 +0000

Im trying use as portlet application in JBoss Portal. but not work.

By: Luke Samad

Luke Samad — Fri, 17 Sep 2010 20:08:57 +0000

Nicely done, well written and goo catch too. Thanks to all….

Luke S.

By: Devon

Devon — Thu, 11 Feb 2010 15:31:07 +0000

Right again! Man I need to hire you to review all my code:) Thanks!

By: Ondrej Medek

Ondrej Medek — Thu, 11 Feb 2010 08:05:38 +0000

Hi Devon.

you can also set the time zone in the static class initializer, put it just bellow the HTTP_DATE_FORMAT declaration:

private static final DateFormat HTTP_DATE_FORMAT = new SimpleDateFormat(“EEE, d MMM yyyy HH:mm:ss zzz”, Locale.ROOT);
static {
HTTP_DATE_FORMAT.setTimeZone(TimeZone.getTimeZone(“GMT”));
}

By: Devon

Devon — Thu, 11 Feb 2010 03:31:31 +0000

Ondrej,

I don’t want to make a dependancy on commons-lang, but the second suggestion is very good!

I have edited the code to reflect that approach, as in this sort of thing, speed is critical!

Thanks!

By: Ondrej Medek

Ondrej Medek — Wed, 10 Feb 2010 09:35:15 +0000

Hi,
another option is to use thread safe FastDateFormat from commons-lang http://commons.apache.org/lang/api-release/org/apache/commons/lang/time/FastDateFormat.html

Or just make a static instance of the DateFormat and create a separate instance by clone() method each time you need to use it. It’s a little bit faster then to call the constructor, because the constructor has to parse the format string.

By: Devon

Devon — Wed, 15 Apr 2009 14:03:10 +0000

Ack! You’re right! Thanks for the call-out. I’ll update the code shortly to solve that.

———–

Code is updated. Enjoy!

By: Jakub G?uszecki

Jakub G?uszecki — Wed, 15 Apr 2009 09:35:33 +0000

Hey
Not a good idea to share DateFormat instance across multiple threads.